Re: [PATCH v7 2/6] dt-bindings: mfd: Binding for RTL8231
From: Rob Herring
Date: Tue Nov 18 2025 - 20:38:09 EST
On Tue, Nov 18, 2025 at 3:57 PM Sander Vanheule <sander@xxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On Tue, 2025-11-18 at 15:28 -0600, Rob Herring wrote:
> > On Mon, Nov 17, 2025 at 3:52 PM Sander Vanheule <sander@xxxxxxxxxxxxx> wrote:
> > > +patternProperties:
> > > + "-pins$":
> > > + type: object
> > > + $ref: /schemas/pinctrl/pinmux-node.yaml#
> >
> > additionalProperties: false
>
> In this case dt_binding_check doesn't recognize input-debounce. The following seems to
> work for the provided example:
>
> - $ref: /schemas/pinctrl/pinmux-node.yaml#
> + allOf:
> + - $ref: /schemas/pinctrl/pincfg-node.yaml#
> + - $ref: /schemas/pinctrl/pinmux-node.yaml#
> +
> + additionalProperties: false
>
>
> with this included in the led node properties:
> + input-debounce: true
>
> If I understand correctly, "unevaluatedProperties: false" (like for the leds binding)
> would allow everything from the referenced pincfg-node and pinmux-node schemas, which is
> more than is actually supported by this device.
Yes, that works too. The first way lets you be explicit about which
referenced properties are used, but either way is fine. If it is only
1 property, then I'd probably go with the first way.
Rob