Re: [PATCH libcrypto 1/2] array_size: introduce min_array_size() function decoration
From: Eric Biggers
Date: Tue Nov 18 2025 - 18:24:39 EST
On Tue, Nov 18, 2025 at 06:02:39PM +0100, Jason A. Donenfeld wrote:
> diff --git a/include/linux/array_size.h b/include/linux/array_size.h
> index 06d7d83196ca..8671aee11479 100644
> --- a/include/linux/array_size.h
> +++ b/include/linux/array_size.h
I think compiler.h would be a better place?
> @@ -10,4 +10,11 @@
> */
> #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>
> +/**
> + * min_array_size - parameter decoration to hint to the compiler that the
> + * passed array should have at least @n elements
> + * @n: minimum number of elements, after which the compiler may warn
> + */
> +#define min_array_size(n) static n
"after which" => "below which"
Anyway, I actually have a slight preference for just using 'static n'
directly, without the unnecessary min_array_size() wrapper. But if
other people prefer min_array_size(), that's fine with me too. At least
this is what Linus asked for
(https://lore.kernel.org/linux-crypto/CAHk-=wj6J5L5Y+oHc-i9BrDONpSbtt=iEemcyUm3dYnZ3pXxxg@xxxxxxxxxxxxxx/).
- Eric