Re: [PATCH v2 05/15] gpio: pxa: Use modern PM macros

[Robert Jarzmik]

Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:

> On Tue, Nov 18, 2025 at 2:50 AM Jisheng Zhang 
> <jszhang@xxxxxxxxxx> wrote:
> > Use the modern PM macros for the suspend and resume functions 
> > to be
> > automatically dropped by the compiler when CONFIG_PM or
> > CONFIG_PM_SLEEP are disabled, without having to use #ifdef 
> > guards.
...zip...
> > -#ifdef CONFIG_PM
> >         unsigned long   saved_gplr;
> >         unsigned long   saved_gpdr;
> >         unsigned long   saved_grer;
> >         unsigned long   saved_gfer;
> > -#endif

Actually this is not equivalent to what was there before.

With Jisheng's patch, with CONFIG_PM disabled, he adds 16 bytes to 
the
structure. You might thing today, 16 bytes is nothing. True, but 
on a
64MB RAM devices, it's something.

That might not be a reason to reject the patch, but it's not only 
a
"modernisation patch".

Cheers.

--
Robert