Re: [PATCH v5 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

[Krzysztof Kozlowski]

On 23/11/2025 10:42, Krzysztof Kozlowski wrote:
> On 23/11/2025 01:36, Rogerio Pimentel wrote:
>> The FRDM-i.MX8MP is an NXP development platform based on the i.MX8M Plus
>> SoC, featuring a quad Cortex-A53, Cortex-M7 co-processor, 4GB LPDDR4,
>> 32GB eMMC, Wi-Fi 6/Bluetooth 5.4/802.15.4 tri-radio, Ethernet, HDMI/MIPI
>> display interfaces, camera connectors, and standard expansion headers.
>>
>> Based on the device tree found in the NXP repository at github
>> https://github.com/nxp-imx-support/meta-imx-frdm and on imx8mp-evk
>> board kernel mainline device tree.
>>
>> This is a basic device tree supporting:
>>
>>  - Quad Cortex-A53
>>  - 4GB LPDDR4 DRAM
>>  - PCA9450C PMIC with regulators
>>  - Two NXP PCAL6416 GPIO expanders
>>  - RGB LEDs via GPIO expander
>>  - I2C1, I2C2, I2C3 controllers
>>  - UART2 (console) and UART3 (with RTS/CTS)
>>  - USDHC3 (8-bit eMMC)
>>  - SNVS power key (onboard power button)
>>
>> Author: Xiaofeng Wei <xiaofeng.wei@xxxxxxx>
> 
> There is no such tag. Use git commit --amend --reset-author to set the
> author.
> 
>> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@xxxxxxx>
>>
>> Co-developed-by: Joseph Guo <qijian.guo@xxxxxxx>
>> Signed-off-by: Joseph Guo <qijian.guo@xxxxxxx>
>>
> 
> There is never blank line between tags.
> 
>> Co-developed-by: Steven Yang <steven.yang@xxxxxxx>
>> Signed-off-by: Steven Yang <steven.yang@xxxxxxx>
>>
>> Co-developed-by: Lei Xu <lei.xu@xxxxxxx>
>> Signed-off-by: Lei Xu <lei.xu@xxxxxxx>
>>
>> Co-developed-by: Rogerio Pimentel <rpimentel.silva@xxxxxxxxx>
>> Signed-off-by: Rogerio Pimentel <rpimentel.silva@xxxxxxxxx>
>> ---
>>
>> Changes in v5:
>>
>>  - Replace underscores (_) in node names with dashes (-)
>>  - Added missing Co-developed-by and Signed-off-by tags from all contributors
> 
> I assume you actually saw these SoBs in the code you took as your base?
> Remember, do not add SoBs which were never present in the original work
> (if company asks you, you can politely reply that they need to read what
> SoB means)
> 
> That's anyway weirdly a lot of co-developed tags, are you sure they
> wrote the code you took as the base here?

Although I think you mentioned you wanted all these last time, so it's
fine. Although I did not think you will literally use that syntax and
literally all the tags from Daniel's responses, because the syntax was
not correct.

Best regards,
Krzysztof