Re: [PATCH V3 13/14] LoongArch: Adjust default config files for 32BIT/64BIT

[Huacai Chen]

Hi, Thomas,

On Sat, Nov 22, 2025 at 5:45 PM Thomas Weißschuh <thomas@xxxxxxxx> wrote:
>
> On 2025-11-22 12:36:33+0800, Huacai Chen wrote:
> > Add loongson32_defconfig (for 32BIT) and rename loongson3_defconfig to
> > loongson64_defconfig (for 64BIT).
> >
> > Also adjust graphics drivers, such as FB_EFI is replaced with EFIDRM.
> >
> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > ---
> >  arch/loongarch/Makefile                       |    7 +-
> >  arch/loongarch/configs/loongson32_defconfig   | 1104 +++++++++++++++++
> >  ...ongson3_defconfig => loongson64_defconfig} |    6 +-
> >  3 files changed, 1113 insertions(+), 4 deletions(-)
> >  create mode 100644 arch/loongarch/configs/loongson32_defconfig
> >  rename arch/loongarch/configs/{loongson3_defconfig => loongson64_defconfig} (99%)
> >
> > diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> > index 96ca1a688984..cf9373786969 100644
> > --- a/arch/loongarch/Makefile
> > +++ b/arch/loongarch/Makefile
> > @@ -5,7 +5,12 @@
> >
> >  boot := arch/loongarch/boot
> >
> > -KBUILD_DEFCONFIG := loongson3_defconfig
> > +ifdef CONFIG_32BIT
>
> Testing for CONFIG options here doesn't make sense, as the config is not yet
> created. Either test for $(ARCH) or uname or just use one unconditionally.
> Also as mentioned before, snippets can reduce the duplication.
Thank you for your clarification. But $(ARCH) also doesn't make sense
because it is always "loongarch".

'uname' is an option but I think it doesn't work for cross compile?


Huacai

>
> > +KBUILD_DEFCONFIG := loongson32_defconfig
> > +else
> > +KBUILD_DEFCONFIG := loongson64_defconfig
> > +endif
> > +
> >  KBUILD_DTBS      := dtbs
> >
> >  image-name-y                 := vmlinux
>
> (...)