Re: [PATCH 0/6] arch, sysfb: Move screen and edid info into single place
From: Thomas Zimmermann
Date: Fri Nov 21 2025 - 11:09:46 EST
Am 21.11.25 um 17:08 schrieb Thomas Zimmermann:
Hi
Am 21.11.25 um 16:56 schrieb Ard Biesheuvel:
On Fri, 21 Nov 2025 at 16:53, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:HiI don't mind queueing all of it, but I did get a conflict on
Am 21.11.25 um 16:16 schrieb Ard Biesheuvel:
On Fri, 21 Nov 2025 at 16:10, Arnd Bergmann <arnd@xxxxxxxx> wrote:Thanks
On Fri, Nov 21, 2025, at 14:36, Thomas Zimmermann wrote:
Replace screen_info and edid_info with sysfb_primary_device of typeThis all looks good to me,
struct sysfb_display_info. Update all users.
Sysfb DRM drivers currently fetch the global edid_info directly, when
they should get that information together with the screen_info from their
device. Wrapping screen_info and edid_info in sysfb_primary_display and
passing this to drivers enables this.
Replacing both with sysfb_primary_display has been motivate by the EFI
stub. EFI wants to transfer EDID via config table in a single entry.
Using struct sysfb_display_info this will become easily possible. Hence
accept some churn in architecture code for the long-term improvements.
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
ThanksIt should also bring us one step closer to eventuallyAgreed
disconnecting the x86 boot ABI from the kernel-internal
sysfb_primary_display.
Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
I can take patches 1-2 right away, if that helps during the next cycle.From my sysfb-focused POV, these patches would ideally all go through
the same tree, say efi or generic arch, or whatever fits best. Most of
the other code is only renames anyway.
drivers/pci/vgaarb.c
Probably from a78835b86a44 ("PCI/VGA: Select SCREEN_INFO on X86")
https://lore.kernel.org/all/20251013220829.1536292-1-superm1@xxxxxxxxxx/
that I have in my tree. You can fix it by replacing screen_info with sysfb_primary_display.screen. The later merge conflict seems manageable.
Best regards
Thomas
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)