Re: [PATCH] staging: rtl8723bs: core: fix block comment style issues

From: Dan Carpenter

Date: Wed Nov 19 2025 - 06:36:58 EST


On Tue, Nov 18, 2025 at 10:26:40PM -0800, Artur Stupa wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 027b2dd0a4b9..a5234fdbf984 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -133,8 +133,8 @@ u8 *rtw_set_ie(u8 *pbuf,
> }
>
> /*----------------------------------------------------------------------------
> -index: the information element id index, limit is the limit for search
> ------------------------------------------------------------------------------*/
> + * index: the information element id index, limit is the limit for search
> + *--------------------------------------------------------------------------*/

We generally don't like these "****************" or "-----------------" lines.

[ snip ]

> @@ -1691,12 +1691,11 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len)
> /* pmlmeext->bcn_delay_ratio[delay_ms] = (pmlmeext->bcn_delay_cnt[delay_ms] * 100) /pmlmeext->bcn_cnt; */
>
> /*
> -
> - for (i = 0; i<9; i++)
> - {
> - pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]);
> - }
> -*/
> + * for (i = 0; i<9; i++)
> + * {
> + * pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]);
> + * }
> + */

Delete dead code. Don't reformat it.

regards,
dan carpenter