[PATCH next] mm/damon/tests/sysfs-kunit: fix use after free on error path

From: Dan Carpenter

Date: Fri Nov 21 2025 - 08:36:43 EST


Re-order these frees to avoid dereferencing "sysfs_target" after it has
been freed.

Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
mm/damon/tests/sysfs-kunit.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/tests/sysfs-kunit.h b/mm/damon/tests/sysfs-kunit.h
index ce7218469f20..0c665ed255a3 100644
--- a/mm/damon/tests/sysfs-kunit.h
+++ b/mm/damon/tests/sysfs-kunit.h
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test)
if (!ctx) {
kfree(sysfs_targets->targets_arr);
kfree(sysfs_targets);
- kfree(sysfs_target);
kfree(sysfs_target->regions);
+ kfree(sysfs_target);
kunit_skip(test, "ctx alloc fail");
}

--
2.51.0