Re: [PATCH v3 5/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the dax device driver

[Ira Weiny]

Michal Clapinski wrote:
> Signed-off-by: Michal Clapinski <mclapinski@xxxxxxxxxx>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Sorry for the delay.  I picked up this series but I find that this breaks
the device-dax and daxctl-create.sh.

I was able to fix device-dax with a sleep, see below.

I'm not 100% sure what to do about this.

I don't want to sprinkle sleeps around the tests.  daxctl-create.sh also
randomly fail due to the races introduced.  So not sure exactly where to
sprinkle them without more work.

Could dropping just this patch and landing the others achieve most of what
you need?

Ira

diff --git a/test/device-dax.c b/test/device-dax.c
index 49c9bc8b1748..817c76b0a88b 100644
--- a/test/device-dax.c
+++ b/test/device-dax.c
@@ -246,6 +246,7 @@ static int __test_device_dax(unsigned long align, int loglevel,
                goto out;
        }

+sleep(1);
        sprintf(path, "/dev/%s", daxctl_dev_get_devname(dev));
        fd = open(path, O_RDONLY);
        if (fd < 0) {