Re: [PATCH v3] drm/tilcdc: Fix removal actions in case of failed probe
From: kernel test robot
Date: Tue Nov 18 2025 - 22:14:53 EST
Hi Kory,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.18-rc6 next-20251118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kory-Maincent/drm-tilcdc-Fix-removal-actions-in-case-of-failed-probe/20251118-214022
base: linus/master
patch link: https://lore.kernel.org/r/20251118133850.125561-1-kory.maincent%40bootlin.com
patch subject: [PATCH v3] drm/tilcdc: Fix removal actions in case of failed probe
config: arm-randconfig-004-20251119 (https://download.01.org/0day-ci/archive/20251119/202511191045.bW4DdgHX-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511191045.bW4DdgHX-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511191045.bW4DdgHX-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/tilcdc/tilcdc_drv.c: In function 'tilcdc_init':
>> drivers/gpu/drm/tilcdc/tilcdc_drv.c:391:1: warning: label 'destroy_crtc' defined but not used [-Wunused-label]
391 | destroy_crtc:
| ^~~~~~~~~~~~
vim +/destroy_crtc +391 drivers/gpu/drm/tilcdc/tilcdc_drv.c
329
330 if (priv->is_componentized) {
331 ret = component_bind_all(dev, ddev);
332 if (ret < 0)
333 goto unregister_cpufreq_notif;
334
335 ret = tilcdc_add_component_encoder(ddev);
336 if (ret < 0)
337 goto unbind_component;
338 } else {
339 ret = tilcdc_attach_external_device(ddev);
340 if (ret)
341 goto unregister_cpufreq_notif;
342 }
343
344 if (!priv->external_connector &&
345 ((priv->num_encoders == 0) || (priv->num_connectors == 0))) {
346 dev_err(dev, "no encoders/connectors found\n");
347 ret = -EPROBE_DEFER;
348 goto unbind_component;
349 }
350
351 ret = drm_vblank_init(ddev, 1);
352 if (ret < 0) {
353 dev_err(dev, "failed to initialize vblank\n");
354 goto unbind_component;
355 }
356
357 ret = platform_get_irq(pdev, 0);
358 if (ret < 0)
359 goto unbind_component;
360 priv->irq = ret;
361
362 ret = tilcdc_irq_install(ddev, priv->irq);
363 if (ret < 0) {
364 dev_err(dev, "failed to install IRQ handler\n");
365 goto unbind_component;
366 }
367
368 drm_mode_config_reset(ddev);
369
370 drm_kms_helper_poll_init(ddev);
371
372 ret = drm_dev_register(ddev, 0);
373 if (ret)
374 goto stop_poll;
375
376 drm_client_setup_with_color_mode(ddev, bpp);
377
378 return 0;
379
380 stop_poll:
381 drm_kms_helper_poll_fini(ddev);
382 tilcdc_irq_uninstall(ddev);
383 unbind_component:
384 if (priv->is_componentized)
385 component_unbind_all(dev, ddev);
386 unregister_cpufreq_notif:
387 #ifdef CONFIG_CPU_FREQ
388 cpufreq_unregister_notifier(&priv->freq_transition,
389 CPUFREQ_TRANSITION_NOTIFIER);
390 #endif
> 391 destroy_crtc:
392 tilcdc_crtc_destroy(priv->crtc);
393 disable_pm:
394 pm_runtime_disable(dev);
395 clk_put(priv->clk);
396 free_wq:
397 destroy_workqueue(priv->wq);
398 put_drm:
399 platform_set_drvdata(pdev, NULL);
400 ddev->dev_private = NULL;
401 drm_dev_put(ddev);
402
403 return ret;
404 }
405
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki