Re: [PATCH 4/6] mfd: max77759: modify irq configs

[Krzysztof Kozlowski]

On 24/11/2025 07:21, André Draszik wrote:
> 
>>  	if (ret)
>>  		return dev_err_probe(&client->dev, ret,
>>  				     "MAX77759_MAXQ_INT_APCMDRESI failed\n");
>> @@ -633,7 +643,7 @@ static int max77759_probe(struct i2c_client *client)
>>  		return dev_err_probe(&client->dev, -EINVAL,
>>  				     "invalid IRQ: %d\n", client->irq);
>>  
>> -	irq_flags = IRQF_ONESHOT | IRQF_SHARED;
>> +	irq_flags = IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_LOW;
> 
> I don't believe IRQF_TRIGGER_LOW should be added here, as this is board-specific.
> The polarity is meant to be set via DT (and the only current user of this driver
> does so).
> 


If this is the main chip interrupt, then you are right and the code is
obviously wrong. What's more, it is completely unexplained in the commit
msg, because that vague statement cannot be taken as any reasonable
explanation.

Best regards,
Krzysztof