Re: [PATCH v18 1/3] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver
From: Krzysztof Kozlowski
Date: Mon Nov 24 2025 - 02:56:13 EST
On Mon, Nov 24, 2025 at 08:30:38AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 24, 2025 at 02:10:40AM +0700, Nam Tran wrote:
> > The LP5812 is a 4x3 RGB LED driver with an autonomous animation
> > engine and time-cross-multiplexing (TCM) support for up to 12 LEDs
> > or 4 RGB LEDs. It supports both analog (256 levels) and PWM (8-bit)
> > dimming, including exponential PWM for smooth brightness control.
> >
> > Signed-off-by: Nam Tran <trannamatk@xxxxxxxxx>
>
> You received review from me - where did you explain reasons of dropping
> it?
>
> You then received SECOND review from Rob and where did you explain
> reasons of ignoring/dropping it?
>
> You will not get third review, please start respecting our work. Read
> carefully submitting patches document.
I gave it second read and found it, although I admit it is not obvious.
I really do not expect changes to the binding at v15, then again at v17.
Best regards,
Krzysztof