Re: [PATCH V2 4/5] f2fs: ignore discard return value
From: Johannes Thumshirn
Date: Mon Nov 24 2025 - 02:57:08 EST
On 11/24/25 3:58 AM, Chaitanya Kulkarni wrote:
> __blkdev_issue_discard() always returns 0, making the error assignment
> in __submit_discard_cmd() dead code.
>
> Initialize err to 0 and remove the error assignment from the
> __blkdev_issue_discard() call tp err. Move fault injection code into
s/tp/to/
> already present if branch where err is set to -EIO.
>
> This preserves the fault injection behavior while removing dead error
> handling.
Otherwise
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>