Re: [PATCH] mtd: spi-nor: Fix w25q01jv flags

[Michael Walle]

Hi,

>> +		.no_sfdp_flags = SECT_4K,
>
> This one is the right fix and should stand alone in its own patch (first
> in the series if you add support for the block protection).

Only if that flash really doesn't have SFDP. But since the entry
didn't have a size property the flash *must* have SFDP in the first
place.  Otherwise it won't even be probed. Please provide a dump of
the SFDP tables, see [1]. Also please provide the contents of
/sys/kernel/debug/spi-nor/spiN.N/params.

-michael

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements

>
>>  		.fixups = &winbond_nor_multi_die_fixups,
>>  	}, {
>>  		.id = SNOR_ID(0xef, 0x50, 0x12),
>
> Thanks,
> Miquèl

Attachment: signature.asc
Description: PGP signature