Re: [PATCH v6 2/2] s390/pci: Migrate s390 IRQ logic to IRQ domain API

[Tobias Schumacher]

On Fri Nov 21, 2025 at 5:11 PM CET, Heiko Carstens wrote:
> On Fri, Nov 21, 2025 at 04:45:43PM +0100, Tobias Schumacher wrote:
>> +static const struct irq_domain_ops zpci_msi_domain_ops = {
>> +	.alloc = zpci_msi_domain_alloc,
>> +	.free  = zpci_msi_domain_free
> ...
>> +static struct msi_parent_ops zpci_msi_parent_ops = {
>> +	.supported_flags   = MSI_GENERIC_FLAGS_MASK	|
>> +			     MSI_FLAG_PCI_MSIX		|
>> +			     MSI_FLAG_MULTI_PCI_MSI,
>> +	.required_flags	   = MSI_FLAG_USE_DEF_DOM_OPS  |
>> +			     MSI_FLAG_USE_DEF_CHIP_OPS,
>> +	.init_dev_msi_info = zpci_init_dev_msi_info
> ...
>> +	struct irq_domain_info info = {
>> +		.fwnode		= irq_domain_alloc_named_fwnode(fwnode_name),
>> +		.ops		= &zpci_msi_domain_ops
>
> All initializers should come with a comma at the end. Anyway, let's wait
> for Gerd. If he is fine with this version I'll add them when applying.

Sorry for that. Since Gert found another issue, I'll fix this one, too.

Thanks,
Tobias