Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support

[Bhargava Chenna Marreddy]

On Thu, Nov 20, 2025 at 1:14 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > > > +     if (link_info->support_auto_speeds || link_info->support_auto_speeds2 ||
> > > > +         link_info->support_pam4_auto_speeds)
> > > > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> > > > +                              lk_ksettings->link_modes.supported);
> > >
> > > autoneg is more than speed. In fact, 1000BaseX only works are 1G, no
> > > link speed negotiation, but you can negotiate pause. Do any of the
> > > link modes you support work like this?
> >
> > All the speeds we support can be auto-negotiated.
>
> If all the speeds you support can do autoneg, why do you need the if ()

We also have devices which support only fixed speeds, hence this check
is required.

When autoneg is enabled, even if the device supports a single speed like 1G,
it has to go through the process of auto-negotiation.

Thanks,
Bhargava Marreddy

>
>         Andrew

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature