Re: [PATCH 04/10] can: grcan: Add clock handling

[Krzysztof Kozlowski]

On 24/11/2025 10:46, Arun Muthusamy wrote:
> Hi Krzysztof,
> 
> Thank you for your thorough review. I wanted to get your guidance 
> regarding the clock property in the DT binding.
> 
> In the binding, I included the clocks property with maxItems: 1 to 
> indicate that a clock should be described. The driver calls:

Ah, you added clocks, I completely missed it.

> 
> clk = devm_clk_get(dev, NULL);
> 
> Since we pass NULL, the driver always requests the first (and only) 
> clock from the clocks property

Yes this is correct.

.
> 
> I want to ensure the binding is fully compliant with the Linux DT ABI. 

It is fine, please ignore my comment. It was a mistake.


Best regards,
Krzysztof