Re: [PATCH v5 08/23] KVM: s390: KVM page table management functions: allocation

[Janosch Frank]

On 11/24/25 12:55, Claudio Imbrenda wrote:
> Add page table management functions to be used for KVM guest (gmap)
> page tables.
>
> This patch adds the boilerplate and functions for the allocation and
> deallocation of DAT tables.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>

What's the cache for, why did you add it?

> ---
>   arch/s390/kvm/Makefile     |   1 +
>   arch/s390/kvm/dat.c        | 103 +++++++++++++++++++++++++++++++++++++
>   arch/s390/kvm/dat.h        |  77 +++++++++++++++++++++++++++
>   arch/s390/mm/page-states.c |   1 +
>   4 files changed, 182 insertions(+)
>   create mode 100644 arch/s390/kvm/dat.c
>
> diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile
> index 9a723c48b05a..84315d2f75fb 100644
> --- a/arch/s390/kvm/Makefile
> +++ b/arch/s390/kvm/Makefile
> @@ -9,6 +9,7 @@ ccflags-y := -Ivirt/kvm -Iarch/s390/kvm
>   
>   kvm-y += kvm-s390.o intercept.o interrupt.o priv.o sigp.o
>   kvm-y += diag.o gaccess.o guestdbg.o vsie.o pv.o gmap-vsie.o
> +kvm-y += dat.o
>   
>   kvm-$(CONFIG_VFIO_PCI_ZDEV_KVM) += pci.o
>   obj-$(CONFIG_KVM) += kvm.o
> diff --git a/arch/s390/kvm/dat.c b/arch/s390/kvm/dat.c
> new file mode 100644
> index 000000000000..c324a27f379f
> --- /dev/null
> +++ b/arch/s390/kvm/dat.c
> @@ -0,0 +1,103 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + *  KVM guest address space mapping code
> + *
> + *    Copyright IBM Corp. 2007, 2020, 2024

Should definitely add 2025

> + *    Author(s): Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
> + *		 Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> + *		 David Hildenbrand <david@xxxxxxxxxx>
> + *		 Janosch Frank <frankja@xxxxxxxxxxxxx>

Did you retain the authors here because you bring in code from other 
files with these authors in the future?