Re: [PATCH v1 2/3] perf pmu: Add PMU kind to simplify differentiating
From: Anubhav Shelat
Date: Mon Nov 24 2025 - 07:34:39 EST
On Fri, Nov 14, 2025 at 10:06 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> +static inline enum pmu_kind perf_pmu__kind(const struct perf_pmu *pmu)
> +{
> + __u32 type;
> +
> + if (!pmu)
> + return PERF_PMU_KIND_PE;
> +
> + type = pmu->type;
> + if (type <= PERF_PMU_TYPE_PE_END)
> + return PERF_PMU_KIND_PE;
> + if (type <= PERF_PMU_TYPE_DRM_END)
> + return PERF_PMU_KIND_DRM;
> + if (type <= PERF_PMU_TYPE_DRM_END)
> + return PERF_PMU_KIND_DRM;
> + if (type <= PERF_PMU_TYPE_HWMON_END)
> + return PERF_PMU_KIND_HWMON;
> + if (type == PERF_PMU_TYPE_TOOL)
> + return PERF_PMU_KIND_TOOL;
> + return PERF_PMU_KIND_FAKE;
> +}
> +
Looks like there's a duplicate check for PERF_PMU_TYPE_DRM_END.