Re: [PATCH] xfs: fix confused tracepoints in xfs_reflink_end_atomic_cow()
From: John Garry
Date: Mon Nov 24 2025 - 09:26:15 EST
On 24/11/2025 14:04, Christoph Hellwig wrote:
On Mon, Nov 24, 2025 at 10:57:24AM +0000, John Garry wrote:
Commit d6f215f35963 might be able to explain that.
I don't think so.
I am just pointing out why it was changed to use a separate transaction
per extent [and why the cow end handler for atomic writes is different].
That commit splits up the operation so to avoid
doing the entire operation in a single transaction, and the rationale
for this is sound. But the atomic work showed that it went to far,
because we can still batch up a fair amount of conversions. I think
the argument of allowing to batch up as many transactions as we allow
in an atomic write still makes perfect sense.
Sure, Darrick knows more about this than me (so I'll let him comment).