Re: [PATCH v2 1/3] staging: rtl8723bs: Rename camel case enumeration

[Greg Kroah-Hartman]

On Mon, Nov 10, 2025 at 07:49:16PM +0000, Bryant Boatright wrote:
> Adhere to Linux kernel style.
> 
> Reported by checkpatch:
> 
> CHECK: Avoid CamelCase: <ParseRes>
> CHECK: Avoid CamelCase: <ParseFailed>
> CHECK: Avoid CamelCase: <ParseUnknown>
> CHECK: Avoid CamelCase: <ParseOK>

If you are changing the name, let's pick something that makes sense:

> -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> +enum parse_res { PARSE_OK = 0, PARSE_UNKNOWN = 1, PARSE_FAILED = -1 };

These should be on multiple lines too, right?

Anway, "parse_res" doesn't make much sense, how about "parse_state"?
"parse_result"?  Something else?

naming is hard :)

thanks,

greg k-h