Re: [PATCH] staging: gpib: Clean-up commented-out code
From: Adam
Date: Mon Nov 24 2025 - 12:00:50 EST
Oh, I will make a new patch then. It is in the same place in the
master branch. I should make the patch from another branch, right?
On Mon, Nov 24, 2025 at 7:54 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 17, 2025 at 12:20:20PM +0300, Adam Quandour wrote:
> > Remove unused code.
> >
> > Signed-off-by: Adam Quandour <adam.quandour@xxxxxxxxx>
> > ---
> > drivers/staging/gpib/cb7210/cb7210.c | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
> > index 3e2397898a9b..24c61b151071 100644
> > --- a/drivers/staging/gpib/cb7210/cb7210.c
> > +++ b/drivers/staging/gpib/cb7210/cb7210.c
> > @@ -1290,26 +1290,14 @@ static void cb_gpib_release(struct pcmcia_device *link)
> >
> > static int cb_gpib_suspend(struct pcmcia_device *link)
> > {
> > - //struct local_info *info = link->priv;
> > - //struct struct gpib_board *dev = info->dev;
> > -
> > if (link->open)
> > dev_warn(&link->dev, "Device still open\n");
> > - //netif_device_detach(dev);
> >
> > return 0;
> > }
> >
> > static int cb_gpib_resume(struct pcmcia_device *link)
> > {
> > - //struct local_info *info = link->priv;
> > - //struct struct gpib_board *dev = info->dev;
> > -
> > - /*if (link->open) {
> > - * ni_gpib_probe(dev); / really?
> > - * //netif_device_attach(dev);
> > - *
> > - */
> > return cb_gpib_config(link);
> > }
> >
> > --
> > 2.51.0
> >
>
> The code has now moved directories :(