Re: [PATCH v4 3/9] thermal/drivers/mediatek/lvts: Fail probe if temp_factor is zero
From: Daniel Lezcano
Date: Mon Nov 24 2025 - 12:56:44 EST
On 11/21/25 12:16, Laura Nao wrote:
temp_factor is used in lvts_temp_to_raw() and lvts_raw_to_temp(). If
platform data is incorrect and temp_factor is zero, it could cause a
division by zero. Fail the probe early to prevent a kernel crash.
Signed-off-by: Laura Nao <laura.nao@xxxxxxxxxxxxx>
---
drivers/thermal/mediatek/lvts_thermal.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 1c54d0b75b1a..b49441d82ffd 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -1346,6 +1346,11 @@ static int lvts_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
+ if (!lvts_data->temp_factor)
+ return dev_err_probe(
+ dev, -EINVAL,
+ "temp_factor should never be zero; check platform data.\n");
+
From my POV, this is not really useful. The temp_factor is set for each
version statically in the code. The scope is limited to the driver, IOW
it is not a parameter other subsystems passes to the driver.
If it is NULL, then shame on the submitter who did not test the driver
before sending ;)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog