Re: 回复: [PATCH -next] PCI: cadence: remove unneeded semicolon

From: Bjorn Helgaas
Date: Mon Nov 24 2025 - 13:03:06 EST


On Thu, Nov 20, 2025 at 09:41:43AM +0000, Hans Zhang wrote:
> + Manikandan
>
> -----邮件原件-----
> 发件人: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> 发送时间: 2025年11月20日 17:35
> 收件人: lpieralisi@xxxxxxxxxx
> 抄送: kwilczynski@xxxxxxxxxx; mani@xxxxxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> 主题: [PATCH -next] PCI: cadence: remove unneeded semicolon
>
> [You don't often get email from jiapeng.chong@xxxxxxxxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL
>
> No functional modification involved.
>
> ./drivers/pci/controller/cadence/pcie-cadence.h:217:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27326
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

Squashed this into the commit (f5fa6c33b173 ("PCI: cadence: Add
support for High Perf Architecture (HPA) controller"), no need to
repost this.

There's a rash of this error. Do you know of any others in
drivers/pci/?

> ---
> drivers/pci/controller/cadence/pcie-cadence.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h
> index 717921411ed9..311a13ae46e7 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence.h
> +++ b/drivers/pci/controller/cadence/pcie-cadence.h
> @@ -214,7 +214,7 @@ static inline u32 cdns_reg_bank_to_off(struct cdns_pcie *pcie, enum cdns_pcie_re
> break;
> default:
> break;
> - };
> + }
> return offset;
> }
>
> --
> 2.43.5
>
>