RE: [PATCH v5 4/7] vfio: use vfio_pci_core_setup_barmap to map bar in mmap

From: Shameer Kolothum
Date: Mon Nov 24 2025 - 13:10:38 EST




> -----Original Message-----
> From: Ankit Agrawal <ankita@xxxxxxxxxx>
> Sent: 24 November 2025 11:59
> To: Ankit Agrawal <ankita@xxxxxxxxxx>; jgg@xxxxxxxx; Yishai Hadas
> <yishaih@xxxxxxxxxx>; Shameer Kolothum <skolothumtho@xxxxxxxxxx>;
> kevin.tian@xxxxxxxxx; alex@xxxxxxxxxxx; Aniket Agashe
> <aniketa@xxxxxxxxxx>; Vikram Sethi <vsethi@xxxxxxxxxx>; Matt Ochs
> <mochs@xxxxxxxxxx>
> Cc: Yunxiang.Li@xxxxxxx; yi.l.liu@xxxxxxxxx;
> zhangdongdong@xxxxxxxxxxxxxxxxxx; Avihai Horon <avihaih@xxxxxxxxxx>;
> bhelgaas@xxxxxxxxxx; peterx@xxxxxxxxxx; pstanner@xxxxxxxxxx; Alistair
> Popple <apopple@xxxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Neo Jia <cjia@xxxxxxxxxx>; Kirti Wankhede
> <kwankhede@xxxxxxxxxx>; Tarun Gupta (SW-GPU) <targupta@xxxxxxxxxx>;
> Zhi Wang <zhiw@xxxxxxxxxx>; Dan Williams <danw@xxxxxxxxxx>; Dheeraj
> Nigam <dnigam@xxxxxxxxxx>; Krishnakant Jaju <kjaju@xxxxxxxxxx>
> Subject: [PATCH v5 4/7] vfio: use vfio_pci_core_setup_barmap to map bar in
> mmap
>
> From: Ankit Agrawal <ankita@xxxxxxxxxx>
>
> Remove code duplication in vfio_pci_core_mmap by calling
> vfio_pci_core_setup_barmap to perform the bar mapping.
>
> cc: Donald Dutile <ddutile@xxxxxxxxxx>
> Suggested-by: Alex Williamson <alex@xxxxxxxxxxx>
> Signed-off-by: Ankit Agrawal <ankita@xxxxxxxxxx>

LGTM:
Reviewed-by: Shameer Kolothum <skolothumtho@xxxxxxxxxx>