Re: [PATCH 09/18] rust: proc-macro2: enable support in kbuild

[John Hubbard]

On 11/12/25 3:14 AM, Miguel Ojeda wrote:
> On Mon, Nov 10, 2025 at 8:34 PM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
>>
>> Looks good. But for future code and commit log readers, should
>> we leave a small comment, to explain that this was vendored in,
>> and therefore excluded from "make rustfmt"?
>>
>> An alternative approach might be to create a "vendored" subdir,
>> to make it clear which parts of the Rust for Linux code are
>> special in that way.
> 
> Sure, that can help, I will add it.

A minor thing, but, it looks like maybe this was forgotten or 
overlooked in v2?

> 
> The subdir makes sense, although it makes it into a different level
> than the other crates and I don't see it done with a folder in other
> cases either. Hmm... I will think about it.
> 
> Thanks for taking a look!
> 
> Cheers,
> Miguel


thanks,
-- 
John Hubbard