Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Krzysztof Kozlowski]

On 24/11/2025 12:19, Neeraj Soni wrote:
> Starting with sc7280(kodiak), the ICE will have its own device-tree node.

$ git grep kodiak
Nothing. Please do not introduce some new namings.



> So add the qcom,ice property to reference it.
> 

...

> +    else:
> +      properties:
> +        reg:
> +          minItems: 2
> +          items:
> +            - description: Host controller register map
> +            - description: SD Core register map
> +            - description: CQE register map
> +            - description: Inline Crypto Engine register map
> +        reg-names:
> +          minItems: 2
> +          items:
> +            - const: hc
> +            - const: core
> +            - const: cqhci
> +            - const: ice

No, look at the binding - it says there are variants without core. You
cannot just rewrite everyone here.

I don't get what you want to achieve here, but the amount of errors this
patch generates should make you think whether it is even correct. Or you
never tested this?

Best regards,
Krzysztof