Re: [PATCH 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Krzysztof Kozlowski]

On 24/11/2025 12:19, Neeraj Soni wrote:
> Add an ICE node to kodiak SoC description and enable it by adding a
> phandle to the SDHC node.
> 
> Signed-off-by: Neeraj Soni <neeraj.soni@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index c2ccbb67f800..9d2029a906ce 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -1069,6 +1069,15 @@ opp-384000000 {
>  					opp-avg-kBps = <390000 0>;
>  				};
>  			};
> +
> +			qcom,ice = <&sdhc_ice>;

This wasn't tested, for sure you have warnings - you placed the property
randomly or at the end (even worse...). Please read DTS coding style as
well.


Best regards,
Krzysztof