Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for authentication failures

[Justin Tee]

Hi Daniel,

> The patch itself is okay, nothing against it. But it wont close the bug
> report. blktests nvme/041 just passes because we don't check the return
> code from 'nvme connect' yet. I wanted to add this for a while, time to
> do it.
>
> Furthermore, the test now races with the kernel. If the worker thread in
> the kernel is delayed, the 'nvme disconnect' might still see a controller:
>
>      Test authenticated connection
>     -disconnected 1 controller(s)
>     +disconnected 0 controller(s)
>
> Anyway, I am fine with this change just without the 'Closes' tag.
>
> Tested-by: Daniel Wagner <wagi@xxxxxxxxxx>
> Reviewed-by: Daniel Wagner <wagi@xxxxxxxxxx>

Was under the impression that the issue with 041 is that there is a
lingering reconnect attempt leftover from the “Test unauthenticated
connection (should fail)” portion that interferes with the next “Test
authenticated connection” portion of the blktest.

Through correcting the nvmf_should_reconnect routine, which stops
retrying reconnect when -ENOKEY, there would be no interference in the
second part of the test when nvme connect is with an actual key.  So,
there will be a controller to nvme disconnect, as expected, for the
“Test authenticated connection” portion of the test.

Regards,
Justin