RE: [PATCH net] platform/x86: intel_pmc_ipc: fix ACPI buffer memory leak

[Liu, Yongxin]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, November 25, 2025 8:30
> To: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Cc: Liu, Yongxin <Yongxin.Liu@xxxxxxxxxxxxx>; LKML <linux-
> kernel@xxxxxxxxxxxxxxx>; Netdev <netdev@xxxxxxxxxxxxxxx>;
> david.e.box@xxxxxxxxxxxxxxx; chao.qin@xxxxxxxxx;
> yong.liang.choong@xxxxxxxxxxxxxxx; kuba@xxxxxxxxxx; platform-driver-
> x86@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net] platform/x86: intel_pmc_ipc: fix ACPI buffer
> memory leak
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> > Good catch but this fix doesn't address all possible paths. So please
> > use cleanup.h instead:
> >
> >       union acpi_object *obj __free(kfree) = buffer.pointer;
> >
> > And don't forget to add the #include.
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
>   1.6.5. Using device-managed and cleanup.h constructs¶
> 
>   Low level cleanup constructs (such as __free()) can be used when
>   building APIs and helpers, especially scoped iterators. However,
>   direct use of __free() within networking core and drivers is
>   discouraged. Similar guidance applies to declaring variables
>   mid-function.
> 
>     Andrew

Thank you Ilpo and Andrew for your valuable review.
I will send a V2 to cover all possible paths.


Thanks,
Yongxin

> 
> ---
> pw-bot: cr