Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry count

[Ng, Adrian Ho Yin]

On 11/25/2025 1:59 AM, Frank Li wrote:

> > +
> > +	master->dev_nack_retry_cnt = val;
> > +
> > +	spin_lock_irqsave(&master->devs_lock, flags);
>
> I think you'd better to hold i3c_bus_maintenance_lock() lock to make
> sure not transfer on going.
>
> Frank
Hi Frank

i3c_bus_maintenance_lock is a static function in master.c. So should i 
update it and expose a public helper to take the maintenance lock or 
continue using the existing spin lock to protect the DAT updates?

Thank You
Adrian
> > +	/*
> > +	 * Update DAT entries for all currently attached devices.
> > +	 * We directly iterate through the master's device array.
> > +	 */
> > +	for (i = 0; i < master->maxdevs; i++) {
> > +		/* Skip free/empty slots */