Re: [PATCH v1 07/12] dt-bindings: i2c: Describe SA8255p

[Praveen Talari]

Hi Krzysztof,

Thank you for review.

On 11/22/2025 5:10 PM, Krzysztof Kozlowski wrote:
> On Sat, Nov 22, 2025 at 10:30:13AM +0530, Praveen Talari wrote:
> > +  dmas:
> > +    maxItems: 2
> > +
> > +  dma-names:
> > +    items:
> > +      - const: tx
> > +      - const: rx
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    minItems: 2
>
> Drop

sure, will do it in next version.

> > +    maxItems: 2
> > +
> > +  power-domain-names:
> > +    items:
> > +      - const: power
> > +      - const: perf
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - power-domains
> > +
> > +allOf:
>
> So common SE properties are not applicable? If so explain why in the
> commit msg.

Are you referring to clocks, ICC paths, and pin control?
Please let me know if I’m mistaken.

> > +  - $ref: /schemas/i2c/i2c-controller.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    i2c@a90000 {
> > +        compatible = "qcom,sa8255p-geni-i2c";
> > +        reg = <0xa90000 0x4000>;
> > +        interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
> > +        power-domains = <&scmi0_pd 0>, <&scmi0_dvfs 0>;
> > +        power-domain-names = "power", "perf";
>
> dmas and dma-names

sure.

Thanks,
Praveen

> Best regards,
> Krzysztof