Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

[ally heev]

On Mon, 2025-11-24 at 11:28 -0500, Konstantin Ryabitsev wrote:
> On Mon, Nov 24, 2025 at 09:28:39PM +0530, ally heev wrote:
> > > > > Best regards,
> > > > > -----BEGIN PGP SIGNATURE-----
> > > > > 
> > > > > iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> > > > > HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> > > > > 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> > > > > =A6F+
> > > > > -----END PGP SIGNATURE-----
> > > > 
> > > > You should switch to patatt instead, not signing emails. We don't use
> > > > that, I think at all, unlike patatt which is being actively checked by
> > > > toolkit (b4).
> > > 
> > > It's even more curious. The patch was sent with b4, but I'm pretty sure we
> > > wouldn't have put the PGP signature in like that, so I'm curious how that even
> > > happened.
> > > 
> > > Ally, can you shed some light on that?
> > > 
> > > -K
> > 
> > Yes, I use b4 for my patches. I work on other open source projects
> > which use Github. So, my global git config commit autosign is set to

typo: `tag autosign`

> > `true`, hence you have seen PGP signatures. 
> 
> Interesting! I've not seen this cause PGP signatures to be added to "git show"
> output before. I've tried to replicate it locally, but even if I have a signed
> git commit, I can't make the "gpgsig" header to show up in the output of "git
> show --format=email" (which is what b4 uses). Do you have some local git
> configuration changes that make "gpgsig" fields show up in the output of "git
> show"?
> 
> -K

I think b4 uses tags for patch series. I have checked old
patches(before disabling autosign) and found that signature is only
added on first(cover-letter) of the patch series

Regards,
Ally