[PATCH] media: platform: amd: Fix inverted logic typo in isp4if_is_cmdq_rb_full()

From: Sultan Alsawaf
Date: Mon Nov 24 2025 - 21:48:19 EST


Fixes a regression from "[PATCH v2] media: platform: amd: Big squash of
fixes/cleanup on top of v5 patchset".

When bytes_free is *less than or equal to* the size of a fw command, then
the ringbuf is full. Fix the inverted logic typo that used `>` instead of
`<=` for the comparison.

Resolves low preview frame rate observed in Zoom.

Signed-off-by: Sultan Alsawaf <sultan@xxxxxxxxxxxxxxx>
---
drivers/media/platform/amd/isp4/isp4_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/amd/isp4/isp4_interface.c b/drivers/media/platform/amd/isp4/isp4_interface.c
index 90585b8a4e8c..65e660d715be 100644
--- a/drivers/media/platform/amd/isp4/isp4_interface.c
+++ b/drivers/media/platform/amd/isp4/isp4_interface.c
@@ -260,7 +260,7 @@ static bool isp4if_is_cmdq_rb_full(struct isp4_interface *ispif, enum isp4if_str
* wr_ptr when the ringbuf is full, because rd_ptr == wr_ptr is supposed
* to indicate that the ringbuf is empty.
*/
- return bytes_free > sizeof(struct isp4fw_cmd);
+ return bytes_free <= sizeof(struct isp4fw_cmd);
}

struct isp4if_cmd_element *isp4if_rm_cmd_from_cmdq(struct isp4_interface *ispif, u32 seq_num,
--
2.52.0


--tRrhOE+gN6X1WlJJ--