Re: [PATCH v2 3/4] tools/testing/vma: eliminate dependency on vma->__vm_flags
From: Lorenzo Stoakes
Date: Tue Nov 25 2025 - 04:11:39 EST
On Mon, Nov 24, 2025 at 10:04:36AM -0800, Andrew Morton wrote:
> On Mon, 24 Nov 2025 12:43:18 +0000 Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote:
>
> > It seems that the ordering of things has messed us up a bit here!
> >
> > So this patch (3/4) currently introduces an issue where vm_flags_reset() is
> > missing from the VMA userland tests.
> >
> > Then 4/4, now with the vma_internal.h fixes in place, puts vm_flags_reset()
> > back in place (this was my mistake in the series originally!).
> >
> > But then this fix-patch, now applied as the latest patch from me in mm-new,
> > breaks the tests again by duplicating this function :)
> >
> > So, I'm not sure if too late for rebases - if not, then just squash this
> > into 3/4.
> >
> > If it is - then just drop this patch altogether and we'll live with this
> > being broken for a single commit!
>
> All confused. I dropped the whole series - please resend?
Ack will do shortly.