Re: [PATCH net-next 1/8] i40e: extract GRXRINGS from .get_rxnfc
From: Breno Leitao
Date: Tue Nov 25 2025 - 04:22:24 EST
Hello Jakub,
On Mon, Nov 24, 2025 at 07:48:23PM -0800, Jakub Kicinski wrote:
> On Mon, 24 Nov 2025 10:19:05 -0800 Breno Leitao wrote:
> > + * Returns the number of RX rings.
>
> I suspect you used this format because the rest of the driver does,
Correct. I have jsut followed the other kdoc format in the code.
> but let's avoid adding new kdoc warnings. I think Andy is trying
> to clean up the "Returns" vs "Return:" in Intel drivers..
>
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3530 No description found for return value of 'i40e_get_rx_ring_count'
>
> (similar warnings to first 4 patches of the series)
Ack! I will get them fixed.
Thanks for the review,
--breno