Re: [External] : [v2, net-next 10/12] bng_en: Add initial support for ethtool stats display

[Bhargava Chenna Marreddy]

On Wed, Nov 19, 2025 at 7:37 PM ALOK TIWARI <alok.a.tiwari@xxxxxxxxxx> wrote:
> > +     BNGE_TX_STATS_ENTRY(tx_pause_frames),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_frames),
> > +     BNGE_TX_STATS_ENTRY(tx_jabber_frames),
> > +     BNGE_TX_STATS_ENTRY(tx_fcs_err_frames),
> > +     BNGE_TX_STATS_ENTRY(tx_err),
> > +     BNGE_TX_STATS_ENTRY(tx_fifo_underruns),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri0),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri1),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri2),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri3),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri4),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri5),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri6),
> > +     BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri7),
> > +     BNGE_TX_STATS_ENTRY(tx_eee_lpi_events),
> > +     BNGE_TX_STATS_ENTRY(tx_eee_lpi_duration),
> > +     BNGE_TX_STATS_ENTRY(tx_total_collisions),
> > +     BNGE_TX_STATS_ENTRY(tx_bytes),
> > +     BNGE_TX_STATS_ENTRY(tx_xthol_frames),
> > +     BNGE_TX_STATS_ENTRY(tx_stat_discard),
> > +     BNGE_TX_STATS_ENTRY(tx_stat_error),
>
> RX uses rx_stat_err. Consider using consistent err/error
> same for rx_jbr_frames and tx_jabber_frames

It is consistent with the shared firmware header struct, so we prefer
to keep it like this.

Thanks,
Bhargava Marreddy

>
> > +};
> > +
> > +static const struct {
> > +     long offset;
> > +     char string[ETH_GSTRING_LEN];
> > +} bnge_port_stats_ext_arr[] = {
> > +     BNGE_RX_STATS_EXT_ENTRY(link_down_events),
> > +     BNGE_RX_STATS_EXT_ENTRY(continuous_pause_events),
> > +     BNGE_RX_STATS_EXT_ENTRY(resume_pause_events),
> > +     BNGE_RX_STATS_EXT_ENTRY(continuous_roce_pause_events),
> > +     BNGE_RX_STATS_EXT_ENTRY(resume_roce_pause_events),
> > +     BNGE_RX_STATS_EXT_COS_ENTRIES,
> > +     BNGE_RX_STATS_EXT_PFC_ENTRIES,
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_bits),
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_buffer_passed_threshold),
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_pcs_symbol_err),
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_corrected_bits),
> > +     BNGE_RX_STATS_EXT_DISCARD_COS_ENTRIES,
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_fec_corrected_blocks),
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_fec_uncorrectable_blocks),
> > +     BNGE_RX_STATS_EXT_ENTRY(rx_filter_miss),
> > +};
> > +
> Thanks,
> Alok

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature