Re: [PATCH v3 2/4] mm: simplify and rename mm flags function for clarity
From: Pedro Falcato
Date: Tue Nov 25 2025 - 05:45:27 EST
On Tue, Nov 25, 2025 at 10:01:00AM +0000, Lorenzo Stoakes wrote:
> The __mm_flags_set_word() function is slightly ambiguous - we use 'set' to
> refer to setting individual bits (such as in mm_flags_set()) but here we
> use it to refer to overwriting the value altogether.
>
> Rename it to __mm_flags_overwrite_word() to eliminate this ambiguity.
>
write_word()?
> We additionally simplify the functions, eliminating unnecessary
> bitmap_xxx() operations (the compiler would have optimised these out but
> it's worth being as clear as we can be here).
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
Anyway:
Reviewed-by: Pedro Falcato <pfalcato@xxxxxxx>
--
Pedro