Re: [Patch net-next v3] net: mana: Handle hardware recovery events when probing the device
From: Simon Horman
Date: Tue Nov 25 2025 - 05:51:46 EST
On Thu, Nov 20, 2025 at 03:07:13PM -0800, longli@xxxxxxxxxxxxxxxxxxx wrote:
> From: Long Li <longli@xxxxxxxxxxxxx>
>
> When MANA is being probed, it's possible that hardware is in recovery
> mode and the device may get GDMA_EQE_HWC_RESET_REQUEST over HWC in the
> middle of the probe. Detect such condition and go through the recovery
> service procedure.
>
> Fixes: fbe346ce9d62 ("net: mana: Handle Reset Request from MANA NIC")
If this is a fix, should it be targeted at net rather than net-next?
Alternatively, if it is not a fix for net, then I suggest dropping
the Fixes tag and adding something about commit fbe346ce9d62 ("net: mana:
Handle Reset Request from MANA NIC") to the patch description, above the
tags (with a blank line in between).
> Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> ---
> Changes
> v2: Use a list for handling multiple devices.
> Use disable_delayed_work_sync() on driver exit.
> Replace atomic_t with flags to detect if interrupt happens before probe finishes
>
> v3: Rebase to latest net-next. Change list_for_each_entry_safe() to while(!list_empty()).
Code changes look good to me.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>