Re: [PATCH net v3] net: lan966x: Fix the initialization of taprio
From: Simon Horman
Date: Tue Nov 25 2025 - 09:10:27 EST
On Fri, Nov 21, 2025 at 07:14:11AM +0100, Horatiu Vultur wrote:
> To initialize the taprio block in lan966x, it is required to configure
> the register REVISIT_DLY. The purpose of this register is to set the
> delay before revisit the next gate and the value of this register depends
> on the system clock. The problem is that the we calculated wrong the value
> of the system clock period in picoseconds. The actual system clock is
> ~165.617754MHZ and this correspond to a period of 6038 pico seconds and
> not 15125 as currently set.
>
> Fixes: e462b2717380b4 ("net: lan966x: Add offload support for taprio")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
>
> ---
> v2-v3:
> - start to use the define
>
> v1->v2:
> - add define for system clock and calculate the period in picoseconds
Thanks, I agree with this analysis.
And believe v3 addresses the review of earlier versions.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>