Re: [PATCH v2 1/2] rv: Convert to use lock guard

From: Steven Rostedt
Date: Tue Nov 25 2025 - 14:57:07 EST


On Mon, 17 Nov 2025 09:06:02 +0000
Nam Cao <namcao@xxxxxxxxxxxxx> wrote:

> @@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct file *filp, const char __user *user
> else
> retval = rv_disable_monitor(mon);
>
> - if (!retval)
> - retval = count;
> -
> - break;
> + if (retval)
> + return retval;
> + return count;

No biggy, but I wonder if this would look better as:

return retval ? : count;

-- Steve

> }
>
> - mutex_unlock(&rv_interface_lock);
> return retval;
> }
>