Re: [PATCH 2/2] tracing: Merge struct event_trigger_ops into struct event_command

[Steven Rostedt]

On Tue, 25 Nov 2025 07:01:43 -0600
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> > -static const struct event_trigger_ops event_hist_trigger_ops = {
> > -	.trigger		= event_hist_trigger,
> > -	.print			= event_hist_trigger_print,
> > -	.init			= event_hist_trigger_init,
> > -	.free			= event_hist_trigger_free,
> > -};
> > +static struct event_command trigger_hist_cmd;
> >    
> 
> I don't think this is needed, since the same declaration already
> appears just above the event_hist_trigger_parse() declaration.

No it doesn't. Nice catch. I'll send a v2.

Thanks for the review.

-- Steve