Re: [PATCH 2/6] dt-bindings: mfd: maxim,max77759: add charger child node

[Amit Sunil Dhamne]

On 11/23/25 1:30 AM, Krzysztof Kozlowski wrote:
> On 23/11/2025 09:35, Amit Sunil Dhamne via B4 Relay wrote:
> > From: Amit Sunil Dhamne <amitsd@xxxxxxxxxx>
> >
> > The Maxim MAX77759 MFD includes a charger function, hence add its
> > binding as a property. Also, update the example to include charger.
> >
> > Signed-off-by: Amit Sunil Dhamne <amitsd@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/mfd/maxim,max77759.yaml | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
> > index 525de9ab3c2b..29132f73f2c8 100644
> > --- a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
> > @@ -37,6 +37,9 @@ properties:
> >     nvmem-0:
> >       $ref: /schemas/nvmem/maxim,max77759-nvmem.yaml
> >   
> > +  charger:
> > +    $ref: /schemas/power/supply/maxim,max77759-charger.yaml
> You need to explain dependencies/merging in the cover letter. This patch
> now cannot be merged alone through MFD.
>
> Or just decouple the dependency and list here only compatible, assuming
> this child node even stays.

Would it be okay if I drop this patch from this series and re-send it 
while mentioning the dependency?


> > +
> >   required:
> >     - compatible
> >     - interrupts
> > @@ -95,5 +98,14 @@ examples:
> >                       };
> >                   };
> >               };
> > +
> > +            charger {
> > +                compatible = "maxim,max77759-charger";
> > +                power-supplies = <&maxtcpc>;
> Feels like you miss here battery.

I have added the example in [1]. We can discuss there in case there are 
further concerns.

[1] 
https://lore.kernel.org/all/7ad91325-e881-461d-b39e-6ff15d98b3c5@xxxxxxxxxx/T/#u


BR,

Amit

> Best regards,
> Krzysztof