Re: [PATCH net v1 1/1] idpf: Fix kernel-doc descriptions to avoid warnings

[Andy Shevchenko]

On Wed, Nov 26, 2025 at 08:06:30AM +0000, Loktionov, Aleksandr wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Sent: Wednesday, November 26, 2025 8:54 AM
> > On Wed, Nov 26, 2025 at 07:24:40AM +0000, Loktionov, Aleksandr wrote:
> > > > -----Original Message-----
> > > > From: Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>
> > > > Sent: Wednesday, November 26, 2025 7:30 AM On 11/24/25 18:42, Andy
> > > > Shevchenko wrote:

...

> > > > > - * idpf_tx_splitq_has_room - check if enough Tx splitq resources
> > > > > are available
> > > > > + * idpf_txq_has_room - check if enough Tx splitq resources are
> > > > > + available

> > > Strange idpf_tx_splitq_bump_ntu() is not idpf_txq_has_room Can you
> > > doublecheck?
> > 
> > I didn't get. What do you mean? Please elaborate.
> 
> In the kdoc I see function was renamed: idpf_tx_splitq_has_room -> idpf_txq_has_room
> But I don't see idpf_txq_has_room() function name in the patch.
> Only idpf_tx_splitq_build_flow_desc() before and idpf_tx_res_count_required() after.
> Could it be a mistake?

No, it's not a mistake. This is in the category of fixing other kernel doc issues.
Citing the commit message "...and other warnings."

You can run kernel-doc locally and test.

> Everything else looks good for me.

I believe everything including the above looks good.

> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>

Thank you!

-- 
With Best Regards,
Andy Shevchenko