Re: Feedback provided on question about KMSAN: uninit-value in can_receive

[Prithvi Tambewagh]

Hello Oliver,

Thanks for the feedback! I now understand how struct can_skb_priv is 
reserved in the headroom, more clearly, given that I am relatively new
to kernel development. I agree on your patch. 

I tested it locally  using the reproducer program for this bug provided by
syzbot and it didn't crash the kernel. Also, I checked the patch here

https://lore.kernel.org/linux-can/20191207183418.28868-1-socketcan@xxxxxxxxxxxx/

looking at it, I think your patch will work fine with the above patch as 
well, since data will be accessed at 

skb->data - sizeof(struct can_skb_priv)

which is the intended place for it, according to te action of 
can_skb_reserve() which increases headroom by length 
sizeof(struct can_skb_priv), reserving the space just before skb->data.

I think it solves this specific KMSAN bug. Kindly correct me if I am wrong.

Would you like to fix this bug by sending your patch upstream? Or else
shall I send this patch upstream and mention your name in Suggested-by tag?

Thank you,
Prithvi Tambewagh