Re: [PATCH v2 04/13] tools/nolibc/time: drop invocation of gettimeofday system call

From: Willy Tarreau

Date: Sun Nov 30 2025 - 05:42:23 EST


On Sat, Nov 22, 2025 at 05:59:10PM +0100, Thomas Weißschuh wrote:
> This invocation uses libc types with a system call. While this works
> now, upcoming changes to 'struct timeval' would require type
> conversions. If types are converted anyways, the clock_gettime() based
> fallback can be used everywhere, simplifying the code.

I must confess I'm not happy to see the simple, lightweight and efficient
gettimeofday() quit, with the alternative being a bit bigger, but after
enough testing, aside the code size increase I cannot spot any problem.

> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Acked-by: Willy Tarreau <w@xxxxxx>

Willy