Re: [PATCH net-next v3 1/2] net: phy: phy-c45: add SQI and SQI+ support for OATC14 10Base-T1S PHYs

From: Parthiban.Veerasooran

Date: Sun Nov 30 2025 - 04:13:53 EST


Hi Jakub,

Thank you for reviewing the patch.

On 28/11/25 8:14 am, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, 26 Nov 2025 16:19:54 +0530 Parthiban Veerasooran wrote:
>> /**
>> * struct phy_device - An instance of a PHY
>> *
>> @@ -772,6 +796,8 @@ struct phy_device {
>> /* MACsec management functions */
>> const struct macsec_ops *macsec_ops;
>> #endif
>> +
>> + struct phy_oatc14_sqi_capability oatc14_sqi_capability;
>
> kdoc sayeth:
>
> include/linux/phy.h:800 struct member 'oatc14_sqi_capability' not described in 'phy_device'
Thanks for catching this. Somehow missed my radar. I will add the
description for the struct member 'oatc14_sqi_capability' in the next
version.

Best regards,
Parthiban V
> --
> pw-bot: cr