Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h
From: Andy Shevchenko
Date: Sat Nov 29 2025 - 15:36:00 EST
On Sat, Nov 29, 2025 at 10:34:02PM +0200, Andy Shevchenko wrote:
> On Sat, Nov 29, 2025 at 10:24:55PM +0200, Andy Shevchenko wrote:
> > On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote:
> > > The macro is related to sysfs, but is defined in kernel.h. Move it to
> > > the proper header, and unload the generic kernel.h.
> >
> > Tough guy :-)
> > I hope it builds well in your case.
> >
> > FWIW,
> > https://lore.kernel.org/lkml/20220603172101.49950-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
> > https://lore.kernel.org/lkml/20240212115500.2078463-1-max.kellermann@xxxxxxxxx/
> > https://lore.kernel.org/lkml/20240215093646.3265823-1-max.kellermann@xxxxxxxxx/
> >
> > Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Actually, one thing should be fixed, i.e.
> Documentation/filesystems/sysfs.rst:123:Note as stated in include/linux/kernel.h "OTHER_WRITABLE? ...
And just in case, look into
https://lore.kernel.org/r/20251126214709.2322314-1-andriy.shevchenko@xxxxxxxxxxxxxxx
--
With Best Regards,
Andy Shevchenko