Re: [PATCH net-next v2] selftests: mptcp: Mark xerror __noreturn

[Matthieu Baerts]

Hi Jakub, Ankit,

On 30/11/2025 02:41, Jakub Kicinski wrote:
> On Sat, 29 Nov 2025 19:13:08 +0100 Matthieu Baerts wrote:
>>> +$(OUTPUT)/mptcp_connect: CFLAGS += -I$(top_srcdir)/tools/include
>>> +$(OUTPUT)/mptcp_sockopt: CFLAGS += -I$(top_srcdir)/tools/include
>>> +$(OUTPUT)/mptcp_inq: CFLAGS += -I$(top_srcdir)/tools/include  
> 
> I believe this is being added via MM or kselftest tree at level of the
> main ksft makefile. Since this is a false positive, maybe let's defer
> fixing the issue until after the merge window? When the -I.. flag
> will be implicitly in place?

@Jakub: Thank you for sharing this, I didn't know about that. That makes
sense to wait.

@Ankit: do you mind sending a v3 without the modifications of the
Makefile, and supporting die_perror() in a bit more than 2 weeks or
later, please?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.