Re: [PATCH] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led

[Andy Shevchenko]

On Sat, Nov 29, 2025 at 05:02:46AM +0100, Anton Khirnov wrote:
> kbd_led_set() can sleep, and so may not be used as the brightness_set()
> callback.

> Fixes "BUG: scheduling while atomic" when using this led with a trigger.

It might be a bit confusing with (misspelled) Fixes tag, also it would be
better to provide a few (usually ~3-5) lines of the actual traceback.

...

> -static void kbd_led_set(struct led_classdev *led_cdev,
> -			enum led_brightness value)
> +static int kbd_led_set(struct led_classdev *led_cdev,
> +		       enum led_brightness value)

Now it's exactly 80 characters if located on a single line.

-- 
With Best Regards,
Andy Shevchenko